-
Notifications
You must be signed in to change notification settings - Fork 94
Add a native datetime picker #3063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested briefly using our calendar app and left some feedback.
I thought we would replace the old DateTimePicker entirely instead of creating a new component. Are there specific reasons to create a new component and keep the old component?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise. Didn't test.
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
I would like to start slowly and won't create a big breaking change. Reason: a new picker have to be tested in several places / components. We could do this step a bit later. |
A working demo can be found at nextcloud/mail#7123. |
Note we branched off a stable6 branch and master will be the next major only compatible with Nextcloud 25+, so if needed please backport this pr also to stable6. |
/backport to stable6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Just some non-blocking nit-picks
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this
Add documentation for NcDateTimePickerNative.vue Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
bbed758
to
755fd52
Compare
resolves #1666
Working version with attributes
value
,min
,max
(types):date
,datetime-local
,month
,time
,week
.ToDo / Bugs for "upstream", native implementation are described in #1666
ToDo / Bugs to fix for "wrapper" - NativeDatetimePicker component:
Screenshots:




