small cleanup of small modal size #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
added
enhancement
szaimen
requested review from
a team,
artonge,
skjnldsv and
Pytal
and removed request for
a team
|
Could you explain the reasoning behind this? |
szaimen
commented
Apr 10, 2022
Comment on lines
-728
to
+729
| width: 390px; | ||
| max-width: 95%; | ||
| width: 400px; | ||
| max-width: 90%; |
There was a problem hiding this comment.
Changing 390px to 400px is just for the sake of using a x00 number here instead of a random feeling number. Changing 95% to 90% is in order to align with the other used max values of mostly 90%.
szaimen
commented
Apr 10, 2022
| &:not(&--small) .modal-container { | ||
| .modal-container { |
There was a problem hiding this comment.
Changing this media query to also address the small modal has the reason that I designed the small modal initially to be used e.g. for prompts with a limited height. In reality it gets used in many places mostly with a pretty big height. Adjusting this makes sure that the mobile view is aligned to the other sizes and also looks better, imo.
done |
skjnldsv
approved these changes
Apr 11, 2022
artonge
approved these changes
Apr 11, 2022
|
conflicts |
Signed-off-by: szaimen <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/small-modal
branch
from
73bd0c2
to
fd3d425
Compare
skjnldsv
added
4. to release
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: szaimen szaimen@e.mail.de