Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase the small modal width #2496

Merged
merged 2 commits into from
Feb 25, 2022
Merged

increase the small modal width #2496

merged 2 commits into from
Feb 25, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 14, 2022

Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Feb 14, 2022
@szaimen szaimen added this to the 5.0.1 milestone Feb 14, 2022
@nickvergessen nickvergessen removed their request for review February 15, 2022 09:23
@jancborchardt
Copy link
Contributor

Looks good, but max-width is 100% while max-height is 90% – those should probably be the same, right? Could do 90% (or 95% if needed) on both so it's still a modal-type.

Also @marcoambrosini this is the fix we talked about for the Talk modals. :)

@szaimen
Copy link
Contributor Author

szaimen commented Feb 21, 2022

Looks good, but max-width is 100% while max-height is 90% – those should probably be the same, right? Could do 90% (or 95% if needed)

Not sure about this. I had mobile devices in mind where having as much width as possible is probably desired? But I guess 95% should be fine. What do you think?

@jancborchardt
Copy link
Contributor

We do full width/height for the other ones, but for the small size max 95% to have a little bit of modal-ness would be good. :)

@szaimen
Copy link
Contributor Author

szaimen commented Feb 22, 2022

We do full width/height for the other ones, but for the small size max 95% to have a little bit of modal-ness would be good. :)

fine by me then

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Feb 23, 2022

@marcoambrosini could you give your 👍 if it looks fine to you?

Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goood :)

@szaimen szaimen merged commit d73bc38 into master Feb 25, 2022
@szaimen szaimen deleted the szaimen-patch-1 branch February 25, 2022 09:57
@szaimen szaimen modified the milestones: 5.0.1, 5.1.0 Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants