Allow to add class to native datepicker input #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
requested review from
marcoambrosini,
susnux,
Pytal,
JuliaKirschenheuter and
ChristophWurst
raimund-schluessler
added
enhancement
Pytal
approved these changes
Feb 22, 2023
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/native-datepicker-input-class
branch
from
9aa0e0e
to
6d7dd57
Compare
ChristophWurst
approved these changes
Feb 22, 2023
raimund-schluessler
deleted the
fix/noid/native-datepicker-input-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
inputClassprop to theNcDateTimePickerNativecomponent. This is necessary so the input field gets correctly focused when the datepicker is used in theNcActionInputcomponent. With this PR, the datepicker gets the focus when you use the keyboard to navigate through the actions. Before, there was no way of focusing the datepicker with the keyboard only.