Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase NcSelect border contrast #3552

Merged
merged 1 commit into from Dec 8, 2022
Merged

Increase NcSelect border contrast #3552

merged 1 commit into from Dec 8, 2022

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Dec 8, 2022

Screenshot
Before image
After image

@Pytal
Increase NcSelect border contrast
3a4f3e4 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 8, 2022
@Pytal Pytal added this to the 7.2.0 milestone Dec 8, 2022
@Pytal Pytal self-assigned this Dec 8, 2022
@JuliaKirschenheuter JuliaKirschenheuter merged commit 882cb37 into master Dec 8, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/a11y-select-border branch December 8, 2022 12:09
@skjnldsv skjnldsv mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@artonge artonge artonge approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: select Related to the NcSelect* components
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @JuliaKirschenheuter @artonge