Fix button disable state and reactivity #2622
Merged
+70
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
added
bug
skjnldsv
requested review from
nickvergessen,
jancborchardt,
marcoambrosini and
nimishavijay
skjnldsv
requested review from
raimund-schluessler,
JuliaKirschenheuter and
juliusknorr
|
Very nice! I just wonder whether we should disable the hover feedback for disabled buttons. They still look quite enabled when you hover them. 🤔 |
|
Added more examples |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Done 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2621
Dark theme + different primary colour
Dark theme + black primary colour
Light theme + black primary colour
Light theme + bright primary colour