Add tertiary buttons with background and make them the default #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
requested review from
raimund-schluessler,
juliushaertl,
mejo-,
nimishavijay,
jancborchardt,
skjnldsv,
JuliaKirschenheuter and
GretaD
and removed request for
a team
artonge
approved these changes
Mar 29, 2022
mejo-
approved these changes
Mar 31, 2022
JuliaKirschenheuter
approved these changes
Mar 31, 2022
marcoambrosini
force-pushed
the
feature/noid/tertiary-buttons-default-hover-feedback
branch
from
008a9fc
to
53185a5
Compare
Signed-off-by: marco <marcoambrosini@pm.me>
marcoambrosini
force-pushed
the
feature/noid/tertiary-buttons-default-hover-feedback
branch
from
53185a5
to
f67de01
Compare
marcoambrosini
deleted the
feature/noid/tertiary-buttons-default-hover-feedback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up till now now the icon only button we've been using almost always had a background "highlight" when hovered. This is fine for most buttons unless they have not enough white-space around them (within an input, a bar). So far the button component didn't offer this option. This pr introduces tertiary buttons with background and makes them default.
So to summarise we'd have:
tertiaryuse case: there's enough white-space around the button, so having background feedback is ok. This is what Actions currently haveScreen.Recording.2022-03-29.at.17.56.36.mov
tertiary-no-backgrounduse case: the button has not enough space around it so we rely on opacity to provide the hover feedback.Screen.Recording.2022-03-29.at.18.07.14.mov
docs (how it would actually look):
Screen.Recording.2022-03-29.at.17.50.27.mov
Signed-off-by: marco marcoambrosini@pm.me