Enforce nextcloud code style | Adding eslint linting #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
feat/use-eslint
branch
from
ba61784
to
bb02e2e
Compare
skjnldsv
approved these changes
Jan 12, 2023
skjnldsv
reviewed
Jan 12, 2023
skjnldsv
reviewed
Jan 12, 2023
Comment on lines
+6
to
+23
| "overrides": [ | ||
| { | ||
| "files": ["tests/*.js"], | ||
| "rules": { | ||
| "n/no-unpublished-import": "off", | ||
| // Todo: convert tests to TS then drop overrides below | ||
| "n/no-missing-import": "off", | ||
| "import/no-unresolved": "off", | ||
| "import/extensions": "off" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["*.config.*js"], | ||
| "rules": { | ||
| "n/no-unpublished-import": "off" | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
Would be amazing to upstream that to the esling config 🚀
There was a problem hiding this comment.
"cypress/**/*.js", "cypress/**/*.ts", "*.cy.js", "*.cy.ts" too (cypress)
"*.config.*js", "*.config.*ts"
skjnldsv
reviewed
Jan 12, 2023
susnux
force-pushed
the
feat/use-eslint
branch
from
bb02e2e
to
a93853d
Compare
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
…lders Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
feat/use-eslint
branch
from
a93853d
to
e850495
Compare
skjnldsv
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our eslint config supports TypeScript we would make use of it, what do you think?
I pushed the fixes for problems found as different commits to make reviewing the changes easier (you could review a single commit a time and compare with the description from the commit message), as the changes are quite huge.