Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump check-es-compat from 2.2.0 to 2.2.1 #549

Merged
merged 2 commits into from Jan 11, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2023

Bumps check-es-compat from 2.2.0 to 2.2.1.

Release notes

Sourced from check-es-compat's releases.

v2.2.1 (only check-es-compat)

Only check-es-compat had changes.

#54 Fix wrong error summary and exit code reported

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 7, 2023
Copy link

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 7, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/check-es-compat-2.2.1 branch from c46574b to 989f346 Compare January 7, 2023 10:08
Copy link

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 7, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 7, 2023

/home/runner/work/nextcloud-l10n/nextcloud-l10n/dist/index.js
Error:   13:50  error  ES2020 optional chaining is forbidden  ecmascript-compat/compat
Error:   14:50  error  ES2020 optional chaining is forbidden  ecmascript-compat/compat

@susnux, ring a bell?

@susnux
Copy link
Contributor

susnux commented Jan 8, 2023

ring a bell?

@skjnldsv well I added that check as the discussion was not decided, whether to transpile libraries or not, so that is to make sure we only use syntax supported by our target browsers.
This issue seems to origin from still supporting iOS Safari 12.x which does not support optional chaining.

So when we still want only syntax supported by our browserslist targets, we would have to decrease the target in tsconfig to ES2019.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/check-es-compat-2.2.1 branch from 989f346 to db6fdd2 Compare January 10, 2023 09:41
Copy link

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

dependabot bot and others added 2 commits January 11, 2023 21:18
Bumps [check-es-compat](https://github.com/robatwilliams/es-compat) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/robatwilliams/es-compat/releases)
- [Commits](robatwilliams/es-compat@v2.2.0...v2.2.1)

---
updated-dependencies:
- dependency-name: check-es-compat
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux force-pushed the dependabot/npm_and_yarn/check-es-compat-2.2.1 branch from db6fdd2 to ebcce5d Compare January 11, 2023 20:23
@dependabot dependabot bot merged commit d805769 into master Jan 11, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/check-es-compat-2.2.1 branch January 11, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants