Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle improvements #438

Merged
merged 11 commits into from Aug 11, 2022
Merged

Bundle improvements #438

merged 11 commits into from Aug 11, 2022

Conversation

vinicius73
Copy link

@vinicius73 vinicius73 commented Apr 29, 2022 •
edited

This PR follows changes made in nextcloud-libraries/nextcloud-event-bus#481 and nextcloud-libraries/nextcloud-auth#408

Related: #151

  • Update dependencies
  • Add node test workflow
  • Use rollup as bundler
    • Generate commonjs and ESM bundle compatible.
  • Remove babel
    • Typescript already is able to generate code that is in compliance with es5

@vinicius73 vinicius73 added enhancement New feature or request 3. to review labels Apr 29, 2022
@vinicius73 vinicius73 mentioned this pull request May 5, 2022
Open
Vinicius Reis added 7 commits August 10, 2022 14:29
🔨 use rollup instead of babel
24ca6db 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
🔨 remove babel from jest
8e5c70b 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
👷 add node test workflow
290d994 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
📝 update CHANGELOG.md
2c043e1 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
➕ add missing tslib dependency
5dc22e8 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
📝 improve README.md
6a8860f 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
⬆️ Upgrade dependencies.
f8e2840 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73
Copy link
Author

Waiting for next release of

@vinicius73 vinicius73 mentioned this pull request Aug 11, 2022
Closed
⬆️ Upgrade dependencies.
0cc2555 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73 vinicius73 marked this pull request as ready for review August 11, 2022 15:16
👷 remove node14
66c9be0 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@juliushaertl
Copy link
Contributor

@vinicius73 Mind to add the release action right away?

@juliushaertl
Copy link
Contributor

Well never mind it is already there :)

@juliushaertl juliushaertl reopened this Aug 11, 2022
@vinicius73
Copy link
Author

@vinicius73 Mind to add the release action right away?

Sure

👷 adjust release scripts
9d0b7fb 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
🔖 bump version
c7ec237 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73 vinicius73 merged commit 667aba5 into master Aug 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/bundle-improvements branch August 11, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@st3iny st3iny Awaiting requested review from st3iny

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vinicius73 @juliushaertl @CarlSchwan