Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also update eslint-config-n custom rules #381

Merged
merged 1 commit into from Aug 9, 2022
Merged

Also update eslint-config-n custom rules #381

merged 1 commit into from Aug 9, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 9, 2022

Signed-off-by: John Molakvoæ skjnldsv@protonmail.com

@skjnldsv
Also update eslint-config-n custom rules
1a5a313 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the bug Something isn't working label Aug 9, 2022
@skjnldsv skjnldsv self-assigned this Aug 9, 2022
@nickvergessen nickvergessen merged commit 80f238a into master Aug 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/n-rules branch August 9, 2022 07:04
@susnux
Copy link
Contributor

susnux commented Sep 14, 2022

This should (have) been added to the changelog as this is a "breaking change", because this breaks your CI lint pipelines.
As the change on the no-missing-import rule now enforces using a file extension.

E.g. before this was fine:
import IconPlus from 'vue-material-design-icons/Plus'

Now you are enforced to use
import IconPlus from 'vue-material-design-icons/Plus.vue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@skjnldsv skjnldsv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @susnux @nickvergessen