Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): creating custom categories #5994

Merged
merged 1 commit into from May 15, 2024
Merged

fix(editor): creating custom categories #5994

merged 1 commit into from May 15, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented May 9, 2024

Fix #5993

2024-05-09.10-35-22.mp4

@st3iny
fix(editor): creating custom categories
403ed95 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added 3. to review Waiting for reviews bug regression Regression of a previous working feature labels May 9, 2024
@st3iny st3iny added this to the v4.8.0 milestone May 9, 2024
@st3iny st3iny self-assigned this May 9, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 23.51%. Comparing base (397c78e) to head (403ed95).
Report is 13 commits behind head on main.

Files Patch % Lines
...nents/Editor/Properties/PropertySelectMultiple.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #5994   +/-   ##
=========================================
  Coverage     23.51%   23.51%           
  Complexity      455      455           
=========================================
  Files           246      246           
  Lines         11722    11722           
  Branches       2156     2156           
=========================================
  Hits           2756     2756           
- Misses         8650     8651    +1     
+ Partials        316      315    -1
Flag Coverage Δ
javascript 15.15% <0.00%> (ø)
php 58.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member Author

st3iny commented May 14, 2024

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label May 14, 2024
@miaulalala miaulalala merged commit b2d23f8 into main May 15, 2024
40 of 41 checks passed
@miaulalala miaulalala deleted the fix/editor/custom-categories branch May 15, 2024 16:11
@backportbot backportbot bot mentioned this pull request May 15, 2024
Merged
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug regression Regression of a previous working feature
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.

Creating custom categories is broken
2 participants
@st3iny @miaulalala