Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ie and last 2 versions #3

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

skjnldsv
Copy link
Contributor

@ChristophWurst
Copy link
Contributor

didn't we just want to drop IE for Nextcloud 23?

@ChristophWurst
Copy link
Contributor

like if we change this here now it will also have an influence on some apps that are currently released for Nextcloud 21 and older. we have to make this a major version and document the change in the CHANGELOG

@skjnldsv
Copy link
Contributor Author

didn't we just want to drop IE for Nextcloud 23?

Nextcloud 22.
This pull request drops IE

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but please please please let's not forgot to make this a major version when we release :P

'firefox ESR',
'>0.25%',
'not ie 11',
'not op_mini all',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst
Copy link
Contributor

https://github.com/browserslist/browserslist#best-practices

do we accept cutting out those users? I can't tell how relevant or irrelevant those are for our users as we don't have any hard numbers :/

@skjnldsv
Copy link
Contributor Author

I can't tell how relevant or irrelevant those are for our users as we don't have any hard numbers :/

Have you read https://jamie.build/last-2-versions ?

do we accept cutting out those users?

Yes, we definitely should. Those browsers are usually outdated and dragging us behind. having >0.25% should already satisfy most users and still allow us a wide and clean coverage.

@ChristophWurst ChristophWurst merged commit 73311eb into master Feb 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/remove-ie-and-last-2-versions branch February 22, 2021 11:16
@skjnldsv
Copy link
Contributor Author

Just as a clarification, the default for browserslist includes >0.5%.
I enlarged the scope by using >0.25%. This is already a nice step. I don't think we should go higher, but I'm open to suggestions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants