Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

set userId to username #997

Merged
merged 1 commit into from
Nov 16, 2022
Merged

set userId to username #997

merged 1 commit into from
Nov 16, 2022

Conversation

tobiasKaminsky
Copy link
Member

As suggested in #994

Thanks @bglass 馃帀

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #997 (b8cdd21) into master (d2b81dd) will increase coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
+ Coverage   48.95%   49.10%   +0.14%     
==========================================
  Files         178      178              
  Lines        6678     6678              
  Branches      884      884              
==========================================
+ Hits         3269     3279      +10     
+ Misses       2939     2931       -8     
+ Partials      470      468       -2     
Impacted Files Coverage 螖
...ncloud/android/lib/common/network/WebdavEntry.java 79.28% <0.00%> (+0.39%) 猬嗭笍
...om/owncloud/android/lib/common/OwnCloudClient.java 44.00% <0.00%> (+1.14%) 猬嗭笍
...d/lib/common/operations/RemoteOperationResult.java 46.97% <0.00%> (+1.15%) 猬嗭笍
...lib/resources/files/RemoveFileRemoteOperation.java 88.88% <0.00%> (+16.66%) 猬嗭笍

@AlvaroBrey AlvaroBrey merged commit b428f94 into master Nov 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the fixSampleClient branch November 16, 2022 20:01
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.13.0 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants