Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NextcloudUriDelegate: avoid double-slash in files dav paths #996

Merged
merged 2 commits into from
Nov 15, 2022
Merged

NextcloudUriDelegate: avoid double-slash in files dav paths #996

merged 2 commits into from
Nov 15, 2022

Conversation

AlvaroBrey
Copy link
Member

@AlvaroBrey
NextcloudUriDelegate: avoid double-slash in files dav paths
368e8f2 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey
NextcloudUriDelegateIT: also add tests for empty and root paths
471c23a 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@github-actions
Copy link

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions
Copy link

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@AlvaroBrey AlvaroBrey mentioned this pull request Nov 15, 2022
Closed
@AlvaroBrey AlvaroBrey merged commit e39a3c4 into master Nov 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/double-slash branch November 15, 2022 14:03
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.13.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
NC Android Lib 2.13.0
Development

Successfully merging this pull request may close these issues.

userid not set, request URL wrong, sample-client does not work Double slash in URLs
2 participants
@AlvaroBrey @tobiasKaminsky