ChunkedFileRemoteOperation: correctly use lastModificationTimestamp

[AlvaroBrey]

Fixes nextcloud/android#10900

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[AlvaroBrey]

Fixes nextcloud/android#10900

Confirmed by affected users

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[codecov]

Codecov Report

Merging #985 (08b0ac2) into master (a7e8143) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   48.96%   48.93%   -0.03%     
==========================================
  Files         178      178              
  Lines        6678     6678              
  Branches      884      884              
==========================================
- Hits         3270     3268       -2     
- Misses       2939     2940       +1     
- Partials      469      470       +1     

Impacted Files	Coverage Δ
...ources/files/ChunkedFileUploadRemoteOperation.java	25.58% <0.00%> (ø)
...lib/resources/files/UploadFileRemoteOperation.java	52.08% <ø> (ø)
...wncloud/android/lib/resources/files/FileUtils.java	71.42% <0.00%> (-14.29%)	⬇️
.../java/com/nextcloud/common/NextcloudUriDelegate.kt	83.33% <0.00%> (ø)

[tobiasKaminsky]

Right. Seems we did converting twice.
Can you add info that lastModificationTimestamp must be in seconds, according to unix time?

[AlvaroBrey]

Right. Seems we did converting twice.

No, the problem here was that ChunkedFileRemoteOperation was ignoring the passed in lastModificationTimestamp and instead using file.lastModified()/1000, which gives the value of the copy, not the original.

Can you add info that lastModificationTimestamp must be in seconds, according to unix time?

Done.

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141