Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcAppNavigation in mobile state blocks interacting with dialogs #5385

Open
Antreesy opened this issue Mar 8, 2024 · 4 comments
Open

NcAppNavigation in mobile state blocks interacting with dialogs #5385

Antreesy opened this issue Mar 8, 2024 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: app-navigation Related to the app-navigation component

Comments

@Antreesy
Copy link
Contributor

Antreesy commented Mar 8, 2024

When it's in mobile state, focus trap is attached to toggle, and thus any open dialog would be inaccessible from keyboard (not saying that I couldn't type in TextField)

image

ncdialog-focustrap

Any known PR, where this regression could come from?

Originally posted by @Antreesy in #5335 (comment)

@Antreesy Antreesy added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: app-navigation Related to the app-navigation component labels Mar 8, 2024
@Antreesy Antreesy added this to the 8.10.0 milestone Mar 8, 2024
@ShGKme ShGKme removed this from the 8.10.0 milestone Mar 11, 2024
@adripo
Copy link

adripo commented Mar 21, 2024

The issue is also impacting cospend app. It happens with width < 512px.
julien-nc/cospend-nc#248

When clicking on the textarea, the focus is attached to the logo link instead of the textarea when width < 512px.

width 511px:

2024-03-21_03-41-46-939_brave

width 512px:

2024-03-21_03-46-53-560_brave

@susnux
Copy link
Contributor

susnux commented May 11, 2024

Not sure if the app navigation is the problem, as the same issue happens on the sidebar

@Antreesy
Copy link
Contributor Author

My assumption is that any mounted/visible element with focus trap may affect it

@susnux
Copy link
Contributor

susnux commented May 11, 2024

Yes see #5584 for the sidebar.

Another option would be to watch the style property of a component and when display: none is set (v-show: false) then remove the focus trap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

No branches or pull requests

4 participants