Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NcSelect with :no-wrap="true" styling broken #3808

Closed
raimund-schluessler opened this issue Feb 22, 2023 · 3 comments · Fixed by #3811
Closed

NcSelect with :no-wrap="true" styling broken #3808

raimund-schluessler opened this issue Feb 22, 2023 · 3 comments · Fixed by #3811
Assignees
@susnux
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: select Related to the NcSelect* components regression Regression of a previous working feature
Milestone
7.8.0

Comments

@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Feb 22, 2023 •
edited

@susnux I just noticed that these lines
https://github.com/nextcloud/nextcloud-vue/blob/9dd000a8f8251dc8fa501f995326411497084bf6/src/components/NcSelect/NcSelect.vue#L1025-L1030
added in #3759 create issues when the NcSelect component has :no-wrap="true"set. See here:
Screenshot 2023-02-22 at 12-45-19 Nextcloud Vue Style Guide
@raimund-schluessler raimund-schluessler mentioned this issue Feb 22, 2023
Merged
@raimund-schluessler raimund-schluessler added bug Something isn't working 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature feature: select Related to the NcSelect* components labels Feb 22, 2023
@mejo- mejo- added this to the 7.7.0 milestone Feb 22, 2023
@mejo-
Copy link
Contributor

mejo- commented Feb 22, 2023

To discuss this here rather than in the closed PR:

I think we should get this sorted out before releasing 7.7.0. @susnux would you prefer to look for a fix or to revert the PR for 7.7.0?

@susnux susnux self-assigned this Feb 22, 2023
@susnux
Copy link
Contributor

susnux commented Feb 22, 2023

Is there a date 7.7.0 is scheduled for? Maybe I find some time today, but no later than tomorrow for looking into this.

@mejo-
Copy link
Contributor

mejo- commented Feb 22, 2023

Is there a date 7.7.0 is scheduled for? Maybe I find some time today, but no later than tomorrow for looking into this.

That's perfectly fine, thanks a lot @susnux. Releasing tomorrow should be alright.

@mejo- mejo- modified the milestones: 7.7.0, 7.8.0 Feb 22, 2023
@susnux susnux mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: select Related to the NcSelect* components regression Regression of a previous working feature
Projects
None yet
Milestone
7.8.0
Development

Successfully merging a pull request may close this issue.

fix(NcSelect): Do not squash selected items with no-wrap set nextcloud-libraries/nextcloud-vue
3 participants
@susnux @raimund-schluessler @mejo-