eslint-plugin-node missing as dev/peer dependency?

[nickvergessen]

I was setting up a new app to use Vue

package.json

{
	"name": "files_retention",
	"version": "1.0.0",
	"author": "Joas Schilling <coding@schilljs.com>",
	"license": "agpl",
	"private": true,
	"scripts": {
		"build": "NODE_ENV=production webpack --progress",
		"dev": "NODE_ENV=development webpack --progress",
		"watch": "NODE_ENV=development webpack --progress --watch",
		"lint": "eslint --ext .js,.vue src",
		"lint:fix": "eslint --ext .js,.vue src --fix",
		"stylelint": "stylelint css/*.css css/*.scss src/**/*.scss src/**/*.vue",
		"stylelint:fix": "stylelint css/*.css css/*.scss src/**/*.scss src/**/*.vue --fix"
	},
	"dependencies": {
		"@nextcloud/auth": "^1.3.0",
		"@nextcloud/axios": "^1.10.0",
		"@nextcloud/dialogs": "^3.1.4",
		"@nextcloud/initial-state": "^1.2.1",
		"@nextcloud/router": "^2.0.0",
		"@nextcloud/vue": "^5.4.0",
		"vue": "^2.7.4",
		"vue-material-design-icons": "^5.1.2",
		"vuex": "^3.6.2"
	},
	"engines": {
		"node": "^16.0.0",
		"npm": "^7.0.0 || ^8.0.0"
	},
	"browserslist": [
		"extends @nextcloud/browserslist-config"
	],
	"devDependencies": {
		"@nextcloud/babel-config": "^1.0.0",
		"@nextcloud/browserslist-config": "^2.3.0",
		"@nextcloud/eslint-config": "^8.1.0",
		"@nextcloud/stylelint-config": "^2.1.2",
		"@nextcloud/webpack-vue-config": "^5.2.1"
	}
}

Follow up

1. Run npm i
2. Add .github/workflows/lint-eslint.yml from https://github.com/nextcloud/.github/blob/master/workflow-templates/lint-eslint.yml
3. Push
4. 🛑 Fails https://github.com/nextcloud/files_retention/runs/7740294422?check_suite_focus=true

Run npm run lint

> files_retention@1.0.0 lint
> eslint --ext .js,.vue src


Oops! Something went wrong! :(

ESLint: 8.21.0

ESLint couldn't find the plugin "eslint-plugin-node".

(The package "eslint-plugin-node" was not found when loaded as a Node module from the directory "/home/runner/work/files_retention/files_retention".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-node@latest --save-dev

The plugin "eslint-plugin-node" was referenced from the config file in ".eslintrc.js » @nextcloud/eslint-config".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Error: Process completed with exit code 2.

5. Run npm i eslint-plugin-node --save-dev
6. Push again
7. 🟢 Works https://github.com/nextcloud/files_retention/runs/7740454995?check_suite_focus=true

[skjnldsv]

Fixed

[nickvergessen]

Ref #379