Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom reddit provider to v4 #4985

Merged
merged 3 commits into from Jul 26, 2022
Merged

Conversation

dgrcode
Copy link
Contributor

@dgrcode dgrcode commented Jul 21, 2022

☕️ Reasoning

The docs around Reddit provider were obsolete because they were using a previous version of NextAuth. That resulted in a weird error that led me to the discussion #3204. It seems there was a bug open in a previous repo to update the docs, but the bug seems to have been lost on a repo migration.

In the scopes I've added the same scopes that were previously in the docs, but I've personally only tested with the "identity" scope. With this I mean that the code I've written might not work out of the box. However, given the previous code didn't work either, at worst we're still improving the docs.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

I haven't found any open issue searching for "reddit"

📌 Resources

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-auth ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 8:45AM (UTC)

@vercel vercel bot temporarily deployed to Preview July 21, 2022 09:00 Inactive
@dgrcode
Copy link
Contributor Author

dgrcode commented Jul 24, 2022

@balazsorban44 I just updated my changes to reflect your comment. What do you think?

@vercel vercel bot temporarily deployed to Preview July 24, 2022 18:34 Inactive
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we deep-merge user configs, I could simplify this even more, but you were onto what I intended, thanks!

docs/docs/providers/reddit.md Outdated Show resolved Hide resolved
@balazsorban44 balazsorban44 merged commit e8371ab into nextauthjs:main Jul 26, 2022
@vercel vercel bot temporarily deployed to Preview July 26, 2022 08:45 Inactive
@dgrcode dgrcode deleted the patch-3 branch July 26, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants