Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(providers): typo in GitHub provider scope #4938

Merged
merged 1 commit into from Jul 15, 2022
Merged

fix(providers): typo in GitHub provider scope #4938

merged 1 commit into from Jul 15, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jul 14, 2022 •
edited

Fixes #4934

☕️ Reasoning

scope used a + as a delimiter instead of a whitespace . Thus GitHub did not return a proper access_token to fetch our fallback user emails.

@vercel
Copy link

vercel bot commented Jul 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
next-auth ⬜️ Ignored (Inspect) Jul 14, 2022 at 11:10PM (UTC)

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Jul 14, 2022
ndom91
ndom91 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@balazsorban44 balazsorban44 merged commit bb664a2 into main Jul 15, 2022
@balazsorban44 balazsorban44 deleted the fix/issue-4934 branch July 15, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndom91 ndom91 ndom91 approved these changes

@ThangHuuVu ThangHuuVu Awaiting requested review from ThangHuuVu ThangHuuVu is a code owner

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz

Assignees
No one assigned
Labels
core Refers to `@auth/core` providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github email is undefined v4
2 participants
@balazsorban44 @ndom91