Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rm npm2yarn add npm2yarn2pnpm plugin #4805

Merged
merged 19 commits into from Jul 5, 2022

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Jun 30, 2022

☕️ Reasoning

Test: updated to npm2yarn2pnpm remark plugin, instead of the npm2yarn one we had been using. Since pnpm has become the default package manager we use internally within NextAuth.js as well 👍

Doesn't seem to be working yet though.. 🤔

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

@vercel
Copy link

vercel bot commented Jun 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
next-auth ⬜️ Ignored (Inspect) Jul 5, 2022 at 9:55AM (UTC)

docs/package.json Outdated Show resolved Hide resolved
@ndom91
Copy link
Member Author

ndom91 commented Jul 3, 2022

Not sure why the huge pnpm-lock.yaml change. But the npm2yarn2pnpm thing is finally working. Had to be a named import that is passed to the remarkPlugins array 🤦

@ndom91 ndom91 marked this pull request as ready for review July 3, 2022 11:18
docs/docusaurus.config.js Outdated Show resolved Hide resolved
docs/docusaurus.config.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview July 5, 2022 09:00 Inactive
@balazsorban44
Copy link
Member

Nice! One issue is that there is a blink when reloading the page:

image

Not sure if we can control this though, so it's fine for now. 👍

Could we find something for switching TypeScript/JavaScript as well? 👀

@balazsorban44
Copy link
Member

I ran a local diff on the lock file, it looks like every dependency version was prefixed with registry.npmjs.org/. Example:

image

I'll check where this comes from. 🤔

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44 balazsorban44 merged commit 4d4c276 into main Jul 5, 2022
@balazsorban44 balazsorban44 deleted the ndom91/add-npm2yarn2pnpm-docs-plugin branch July 5, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants