[edge] support request.cookies as a map #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in next Next.js versions, NextRequest.cookies will be an instance of NextCookies which is some kind of a Map, instead of a plain object. This commit checks whether there's a `get` function in req.cookies, and acts accordingly, to make sure we will support newer Next.js versions with Edge Functions/Middleware
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
balazsorban44
approved these changes
Jun 21, 2022
patelnav
reviewed
Jun 28, 2022
| @@ -132,7 +132,10 @@ export class SessionStore { | |||
|
|
|||
| for (const name in req.cookies) { | |||
There was a problem hiding this comment.
@Schniz & @balazsorban44
I think this needs to be a for-of loop for Map to work.
I'm running into this issue where the cookie isn't being read in the middleware
The for-in loop just iterates the properties of the Map object and not the actual constants
There was a problem hiding this comment.
You are totally right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
in next Next.js versions, NextRequest.cookies will be an instance of NextCookies which is
some kind of a Map, instead of a plain object.
This commit checks whether there's a
getfunction in req.cookies, and acts accordingly,to make sure we will support newer Next.js versions with Edge Functions/Middleware
I don't see any tests here for that. I can introduce some, but not sure if it makes sense. Please let me know what to do with this!
🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: INSERT_ISSUE_LINK_HERE
📌 Resources