New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow standard Request
in NextAuthHandler
#4704
Merged
Merged
+15,025
−17,760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
client
Client related code
TypeScript
Issues relating to TypeScript
labels
Jun 13, 2022
🎉 Experimental release published on npm! npm i next-auth@0.0.0-pr.4704.768a1433 yarn add next-auth@0.0.0-pr.4704.768a1433 |
ndom91
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but I haven't tested it
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Client related code
core
Refers to `@auth/core`
pages
providers
TypeScript
Issues relating to TypeScript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Request
will make it easier to migratenext-auth
to other frameworks/runtimes.This PR also adds initial tests for our core and replaces Jest transforms to use SWC
In a follow up PR, I plan to change the result of
NextAuthHandler
to a standardResponse