fix: signIn infer provider type #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "P" type it's not passed in any props, so the result type doesn't understand and return the false type always, Adding the "P" at provider type props.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@balazsorban44 Commenting the issue #4513 that you have mentioned, I think this is exactly what you said, the response of signIn really can be "undefined", and this PR doesn't change that. But I think will be interesting to improve the docs to be more understandable these possibly at it, because the way that is now, it's really confusing, because it affirms the responses is "SignInResponse" type and not "SignInResponse | undefined" If you think it's a good idea, I can do this little improvement on the docs and PR too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Re-opening #4623
Sorry, I really don't saw this string validation, I put a ternary validation to check it's really a RedirectableProviderType, and if is, it's will pass the "P" at the provider props. I checked and the build it's passing now.
🧢 Checklist