Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): make issuer configurable on Salesforce #4658

Merged
merged 1 commit into from May 31, 2022

Conversation

balazsorban44
Copy link
Member

Fixes #4200

☕️ Reasoning

What changes are being made? What feature/bug is being fixed here?

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-auth 🔄 Building (Inspect) May 31, 2022 at 5:02PM (UTC)

@github-actions github-actions bot added core Refers to `@auth/core` providers labels May 31, 2022
@balazsorban44 balazsorban44 merged commit 358b80d into main May 31, 2022
@balazsorban44 balazsorban44 deleted the fix/salesforce-configurable-issuer branch May 31, 2022 17:02
@mrcampbell
Copy link

mrcampbell commented Jun 28, 2022

Are there updated docs for this? All my apps started crashing after this update with this error:

[next-auth][error][OAUTH_CALLBACK_ERROR] 
https://next-auth.js.org/errors#oauth_callback_error unexpected iss value, expected undefined, got: https://login.salesforce.com {
  error: {
    message: 'unexpected iss value, expected undefined, got: https://login.salesforce.com',
    stack: 'RPError: unexpected iss value, expected undefined, got: https://login.salesforce.com\n' +
      '    at Client.validateJWT (/Users/mikecampbell/shep-fly/core/node_modules/openid-client/lib/client.js:906:15)\n' +
      '    at Client.validateIdToken (/Users/mikecampbell/shep-fly/core/node_modules/openid-client/lib/client.js:741:60)\n' +
      '    at Client.callback (/Users/mikecampbell/shep-fly/core/node_modules/openid-client/lib/client.js:486:18)\n' +
      '    at processTicksAndRejections (node:internal/process/task_queues:96:5)\n' +
      '    at async oAuthCallback (/Users/mikecampbell/shep-fly/core/node_modules/next-auth/core/lib/oauth/callback.js:112:16)\n' +
      '    at async Object.callback (/Users/mikecampbell/shep-fly/core/node_modules/next-auth/core/routes/callback.js:50:11)\n' +
      '    at async NextAuthHandler (/Users/mikecampbell/shep-fly/core/node_modules/next-auth/core/index.js:176:28)\n' +
      '    at async NextAuthNextHandler (/Users/mikecampbell/shep-fly/core/node_modules/next-auth/next/index.js:23:19)\n' +
      '    at async /Users/mikecampbell/shep-fly/core/node_modules/next-auth/next/index.js:59:32\n' +
      '    at async Object.apiResolver (/Users/mikecampbell/shep-fly/core/node_modules/next/dist/server/api-utils/node.js:185:9)',
    name: 'RPError'
  },
  providerId: 'salesforce',
  message: 'unexpected iss value, expected undefined, got: https://login.salesforce.com'
}

358b80d#commitcomment-77141516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salesforce Provider sends incorrect request to token endpoint
2 participants