Return always status code 401 in case of any error when using Credentials Provider #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey at maintainers ;-) Is there anything I can do to proceed on this PR? Thanks for any feedback |
|
@TomFreudenberg can you update your branch to sync with |
|
Hi @lluia Done ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
When throwing errors while authorize Credentials, the Status from return should be 401 in any case.
It is unusual to check result for errors but when Status is 200 and OK === true.
🧢 Checklist
🎫 Affected issues
Fixes: #3966
Fixes: #1564
But without changing other than the Status code.