Use relative URL for Signin page callbackUrl #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ThangHuuVu
requested changes
May 13, 2022
ThangHuuVu
reviewed
May 15, 2022
ThangHuuVu
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
As of now, there's no way to determine actual address (protocol, host, port) which end-user access next app within middleware functions. Sign in page 's
callbackUrldoes not behave as expected when next app is behind ssl proxy or load balancer.As a simple fix, using relative URL for
callbackUrlwould restore the expected behavior.🧢 Checklist
🎫 Affected issues
Fixes: #4483
📌 Resources