Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove auth from keycloack url #4391

Merged
merged 1 commit into from Apr 14, 2022
Merged

Conversation

dacitto
Copy link
Contributor

@dacitto dacitto commented Apr 14, 2022

in keycloak 17.0+ , There's a change in endpoints as per the official documentation (https://www.keycloak.org/docs-api/11.0/rest-api/index.html#_users_resource) .
so the new url well be https://my-keycloak-domain.com/realms/My_Realm

Reasoning 💡

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

in keycloak 17.0+ , There's a change in endpoints as per the official documentation (https://www.keycloak.org/docs-api/11.0/rest-api/index.html#_users_resource) .
so the new url well be https://my-keycloak-domain.com/realms/My_Realm
@vercel
Copy link

vercel bot commented Apr 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/VjMDCJaBtdwGqpHppp6DdjV6F5PX
✅ Preview: https://next-auth-git-fork-dacitto-patch-1-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview April 14, 2022 09:04 Inactive
@ndom91
Copy link
Member

ndom91 commented Apr 14, 2022

Hey thanks for this update!

However, as keycloak is often a self-hosted auth solution, there will probably be a lot of people still on the older versions for a while, no?

Maybe we make this configurable.

What do you think?

@balazsorban44
Copy link
Member

I think this is good to merge, as it only changes documentation. issuer is not just configurable, but also required to be configured.

@balazsorban44 balazsorban44 merged commit 82159d3 into nextauthjs:main Apr 14, 2022
@dacitto dacitto deleted the patch-1 branch April 15, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants