Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update JWT docs to reflect JWE changes in v4 #4313

Merged
merged 4 commits into from Apr 5, 2022

Conversation

reconbot
Copy link
Contributor

@reconbot reconbot commented Apr 3, 2022

Change language to be clear about JWT/JWE usage

Reasoning 💡

This PR #3039 changed the defaults for JWT tokens to be encrypted by default (JWE). We have conflicting documentation across the docs site and readme.

Additionatlly this PR #3783 made providing a secret required in production via NEXTAUTH_SECRET or an option.

The chagned sections were conflicting or clear with regards to current behavior.

Checklist 🧢

  • Documentation
  • [ ] Tests
  • Ready to be merged

This PR nextauthjs#3039 changed the defaults for JWT tokens to be encrypted by default (JWE). We have conflicting documentation across the docs site and readme.

Additionatlly this PR nextauthjs#3783 made providing a secret required in production via NEXTAUTH_SECRET or an option.
@vercel
Copy link

vercel bot commented Apr 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/DWVQEqJ8fkeBxsfJNVqj7Dxih5Vw
✅ Preview: https://next-auth-git-fork-reconbot-reconbot-get-clea-d4b883-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview April 3, 2022 13:46 Inactive
@vercel vercel bot temporarily deployed to Preview April 3, 2022 22:03 Inactive
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, but otherwise looks great! Thanks for the clean up!

docs/docs/faq.md Outdated Show resolved Hide resolved
docs/docs/faq.md Outdated Show resolved Hide resolved
Co-authored-by: Nico Domino <yo@ndo.dev>
@vercel vercel bot temporarily deployed to Preview April 4, 2022 21:12 Inactive
Co-authored-by: Nico Domino <yo@ndo.dev>
@vercel vercel bot temporarily deployed to Preview April 4, 2022 21:16 Inactive
@reconbot
Copy link
Contributor Author

reconbot commented Apr 4, 2022

Did them 👍

@reconbot reconbot requested a review from ndom91 April 4, 2022 21:17
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44 balazsorban44 merged commit 63398d4 into nextauthjs:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants