Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile to linkAccount event data #4242

Merged
merged 2 commits into from Jun 24, 2022
Merged

Add profile to linkAccount event data #4242

merged 2 commits into from Jun 24, 2022

Conversation

michaelhays
Copy link
Contributor

Reasoning 💡

Add profile to the linkAccount event data, in order to access OAuth profile fields, such as profile.image.

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

Fixes #4218

@github-actions github-actions bot added core Refers to `@auth/core` TypeScript Issues relating to TypeScript labels Mar 23, 2022
@vercel
Copy link

vercel bot commented Mar 23, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/2UaBss1VcY4ULatbpjgYui6KpXnN
✅ Preview: Failed

@ndom91
Copy link
Member

ndom91 commented Mar 23, 2022

Great, thanks for this addition! Seeing as this isn't a breaking change we can probably release this is the next minor version.

Unfortunately we're currently not doing any releases while we wait on Balazs to be back from break. I will mark this PR as ready to review for then, so I appreciate your patience that we won't be able to merge it right away 😁

@ndom91 ndom91 requested a review from ThangHuuVu March 23, 2022 18:49
@michaelhays
Copy link
Contributor Author

No problem! Appreciate your help

@ndom91 ndom91 added the ready Ready to merge label Mar 23, 2022
ThangHuuVu
ThangHuuVu approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the clean PR 🎉

@carlomallone
Copy link

👍🏽

@martin-fv
Copy link

any update @ndom91 @balazsorban44 ?

@riccardogiorato
Copy link

Any update on this @balazsorban44? I would love to use this to also fix an issue with workos linkAccount

@ndom91
Copy link
Member

ndom91 commented Jun 24, 2022

Fixed up the minor merge conflict.

@vercel
Copy link

vercel bot commented Jun 24, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-auth ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 7:49AM (UTC)

@vercel vercel bot temporarily deployed to Preview June 24, 2022 07:49 Inactive
balazsorban44
balazsorban44 approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for taking so long. 😅

@balazsorban44 balazsorban44 merged commit d8d9ab9 into nextauthjs:main Jun 24, 2022
@anguspiv anguspiv mentioned this pull request Jul 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@ThangHuuVu ThangHuuVu ThangHuuVu approved these changes

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

Assignees
No one assigned
Labels
core Refers to `@auth/core` ready Ready to merge TypeScript Issues relating to TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add profile to linkAccount event data
7 participants
@michaelhays @ndom91 @carlomallone @martin-fv @riccardogiorato @balazsorban44 @ThangHuuVu