New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(adapters): Add next-autth as devDependencies for adapters #4226
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/EMnmgZNAQtZYjtzw4EBo7m8qAvgV [Deployment for 2a33e49 canceled] |
@@ -3,10 +3,6 @@ | |||
"compilerOptions": { | |||
"target": "ES2019", | |||
"module": "commonjs", | |||
"declaration": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove these configs because these configs are present in base.json
. Let's see if it breaks the build 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Man this monorepo stuff ain't simple 😅
@ndom91 fantastic! Can you help me merge it? 🙏 |
Yeah, I'll be online again in an hour or so. But balazs recently removed the hard coded 'dry-run' in the release script. So theoretically it should merge and release successfully via built-in GH action. We can do it together later though if you want 👍 |
This won't release anything, as:
|
Ah okay thanks! Forgot about the |
Reasoning 💡
turborepo
recently made changes so thatpeerDependencies
are not getting prioritized in the topological order in their v1.1.6 release. This makes our build fails because adapters are being built in parallel with corenext-auth
.next-auth
asdevDependencies
for all adapter modules. This should help priotizingnext-auth
to being built first.Checklist 🧢
[ ] DocumentationAffected issues 🎟