fix(providers): profile types

[ubbe-xyz]

Reasoning 💡

When reviewing this PR #4170 we noticed that the types in our provider files were incorrect.

When declaring the options for the provider profile, we were doing this:

export default function Discord<P extends Record<string, any> = DiscordProfile>(

but TS is not able to infer the types correctly as you can see:

However changing it like this:

interface DiscordProfile extends Record<string, any> {
  // ...
}

export default function Discord<P extends DiscordProfile>(

enables TS to pick up the types correctly:

I believe both syntaxes are more or less equivalent to what we want to achieve which is typing the profile object of the provider but allowing extra fields for user flexibility.

Checklist 🧢

• Documentation
• Tests
• Ready to be merged

Affected issues 🎟

None

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/FyyGsKMSx6juN6X7qRw8qeR3EfcC
✅ Preview: https://next-auth-git-fix-providers-types-nextauthjs.vercel.app

[Deployment for 43bd01a canceled]

[ubbe-xyz]

I'm adding this field as it was read optimistically in the below profile() function.

Now that the types work TS was complaining that it wasn't declared in the interface. I believe the contributor just forgot to do so 💭

[ThangHuuVu]

LGTM! I think this would solve #3350 too. I wasn't sure how to solve that issue back then. Nice work! 👍

[ndom91]

Yeah great catch!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
next-auth	✅ Ready (Inspect)	Visit Preview	Apr 22, 2022 at 11:17AM (UTC)