Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): change type of EmailConfig #4097

Merged
merged 3 commits into from Jul 12, 2022
Merged

fix(providers): change type of EmailConfig #4097

merged 3 commits into from Jul 12, 2022

Conversation

nkg168
Copy link
Contributor

@nkg168 nkg168 commented Mar 2, 2022

Reasoning 💡

This change allow to set the well-known service in the mail settings.

Types for argument of createTransport is here.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/nodemailer/index.d.ts#L54

Checklist 🧢

  • [ ] Documentation
  • [ ] Tests
  • Ready to be merged

Affected issues 🎟

@vercel
Copy link

vercel bot commented Mar 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/5Sf3RTEx7MUmmSLXeeHQkJ78T3TF
✅ Preview: Canceled

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Mar 2, 2022
@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-auth ✅ Ready (Inspect) Visit Preview Jun 3, 2022 at 8:21AM (UTC)

@vercel vercel bot temporarily deployed to Preview May 24, 2022 03:50 Inactive
@ThangHuuVu
Copy link
Member

@lluia shall we merge this? 😄

@vercel vercel bot temporarily deployed to Preview June 3, 2022 08:21 Inactive
@balazsorban44 balazsorban44 merged commit 1b91282 into nextauthjs:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants