Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate build commands for core and app #3845

Merged
merged 3 commits into from Feb 18, 2022

Conversation

ThangHuuVu
Copy link
Member

@ThangHuuVu ThangHuuVu commented Feb 6, 2022

Reasoning 💡

Separate build command for next-auth and next-auth-app.

Checklist 🧢

  • [ ] Documentation
  • Move emitDeclarationOnly to next-auth only
  • Tests
  • Ready to be merged

Affected issues 🎟

@vercel
Copy link

vercel bot commented Feb 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/7L8Z4CAub9UCwtdwKmidmaEKWfty
✅ Preview: https://next-auth-git-fork-thanghuuvu-chore-update-bu-8afe80-nextauthjs.vercel.app

[Deployment for 4c8dafb canceled]

@vercel vercel bot temporarily deployed to Preview February 6, 2022 04:10 Inactive
@vercel vercel bot temporarily deployed to Preview February 10, 2022 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview February 13, 2022 18:35 Inactive
@balazsorban44
Copy link
Member

balazsorban44 commented Feb 13, 2022

I don't remember the context here. Could you help? I think we should keep the build command for CI/CD purposes, but we only need to build the core app and the adapter packages right now (later on other framework packages like @next-auth/svelte etc), not the docs (it has its own pipeline at Vercel) or the dev app (never published)

@ThangHuuVu
Copy link
Member Author

@balazsorban44 You mentioned that it's not very common to build app, so I thought this should add some improvements to the pipelines.

I think we should keep the build command for CI/CD purposes, but we only need to build the core app and the adapter packages right now (later on other framework packages like @next-auth/svelte etc), not the docs (it has its own pipeline at Vercel) or the dev app (never published)

I just updated the build command accordingly 👍

@vercel vercel bot temporarily deployed to Preview February 15, 2022 03:05 Inactive
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants