New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): add SimpleLogin oidc #10491
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@alexaka1 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
I am not sure what tests are necessary. I have tested the code with my own website, and users are able to log in with SimpleLogin. I would love some input from a maintainer about tests. |
54a1b4e
to
826cfbe
Compare
826cfbe
to
641e14c
Compare
641e14c
to
71968a9
Compare
71968a9
to
697be86
Compare
697be86
to
c900e5f
Compare
c900e5f
to
852d9d4
Compare
852d9d4
to
45ee797
Compare
This looks pretty good already! Can you add a docs page at Thanks 🙏 |
45ee797
to
bb9572d
Compare
I have included an |
Two minor nit picks,
|
Tbh, I couldn't figure out what the brand color does. But will get them fixed. |
d4b096f
to
c6a3819
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10491 +/- ##
==========================================
- Coverage 38.74% 38.59% -0.15%
==========================================
Files 176 177 +1
Lines 27887 27990 +103
Branches 1223 1224 +1
==========================================
Hits 10804 10804
- Misses 17083 17186 +103 ☔ View full report in Codecov by Sentry. |
* By default, Auth.js assumes that the SimpleLogin provider is | ||
* based on the [Open ID Connect](https://openid.net/specs/openid-connect-core-1_0.html) specification. | ||
* | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line duplicated
* |
* const response = await Auth(request, { | ||
* providers: [SimpleLogin({ clientId: SIMPLELOGIN_CLIENT_ID, clientSecret: SIMPLELOGIN_CLIENT_SECRET })], | ||
* }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm format
* const response = await Auth(request, { | |
* providers: [SimpleLogin({ clientId: SIMPLELOGIN_CLIENT_ID, clientSecret: SIMPLELOGIN_CLIENT_SECRET })], | |
* }) | |
* const response = await Auth(request, { | |
* providers: [ | |
* SimpleLogin({ | |
* clientId: SIMPLELOGIN_CLIENT_ID, | |
* clientSecret: SIMPLELOGIN_CLIENT_SECRET, | |
* }), | |
* ], | |
* }) |
* ``` | ||
* | ||
* #### Configuration | ||
*```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js
to ts
*```js | |
*```ts |
☕️ Reasoning
Adds Sign in with SimpleLogin support.
🧢 Checklist
🎫 Affected issues
📌 Resources