Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github and Discord providers ship incorrect SVGs that blend in with the background colour. #10481

Open
abhishekjaiswar221 opened this issue Apr 4, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good issue to take for first time contributors providers

Comments

@abhishekjaiswar221
Copy link

Provider type

Discord, GitHub

Environment

System:
OS: Windows 11 10.0.22631
CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-11300H @ 3.10GHz
Memory: 1.06 GB / 7.79 GB

Binaries:
Node: 20.9.0 - C:\Program Files\NodeJs\node.EXE
Yarn: 1.22.19 - D:\JSpiders Institute\Piyush Garg Code\piyushgarg-dev\node_modules.bin\yarn.CMD
npm: 9.8.1 - C:\Program Files\NodeJs\npm.CMD
pnpm: 8.14.2 - ~\AppData\Roaming\npm\pnpm.CMD

Browsers:
Edge: Chromium (123.0.2420.65)
Internet Explorer: 11.0.22621.1

npmPackages:
next: ^13.1.1 => 13.4.5
next-auth: ^4.18.10 => 4.22.1
react: 18.2.0 => 18.2.0

Reproduction URL

https://github.com/piyushgarg-dev/piyushgargdev-nextjs/blob/main/pages/api/auth/%5B...nextauth%5D.js

Describe the issue

The SVGs that are delivered by Github and Discord providers are wrong and mix in with the background colour.
It appears that instead of providing light SVG's in dark mode, the providers are shipping dark SVG's in dark mode.
image

How to reproduce

Go to https://www.piyushgarg.dev/
Click Login in the navigation bar.
image

Expected behavior

The providers should ship light SVGs in dark mode and dark SVGs in light mode.

@abhishekjaiswar221 abhishekjaiswar221 added bug Something isn't working providers triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Apr 4, 2024
@abhishekjaiswar221 abhishekjaiswar221 changed the title Github and Discord ships incorrect SVGs that blend in with the background colour. Github and Discord providers ship incorrect SVGs that blend in with the background colour. Apr 4, 2024
@balazsorban44 balazsorban44 added good first issue Good issue to take for first time contributors and removed triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

This issue was marked with the good first issue label by a maintainer.

This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start.

Have a look at the Contributing Guide first.

This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Fixes #1234 to the PR description, where 1234 is the issue number. This will auto-close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please make sure that - if applicable - you add tests for the changes you make.

If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to @mention anyone directly, as we will get notified anyway and will respond as soon as we can)

Note

There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good issue to take for first time contributors providers
Projects
None yet
Development

No branches or pull requests

2 participants