Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub GraphQL import in vulntotal datasources #1445

Merged
merged 3 commits into from May 13, 2024

Conversation

poju3185
Copy link
Contributor

Fix #1443

Change the usage of vulnerabilities.utils.fetch_github_graphql_query to fetchcode.package_versions.github_response in github.py

@keshav-space
Copy link
Member

@poju3185 please add signoff to your commit, and you may want to go through this https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html.

Change the method used to fetch GitHub GraphQL queries in github.py
Shift from vulnerabilities.utils.fetch_github_graphql_query to fetchcode.package_versions.github_response
The change avoids dependencies on Django apps in vulnerabilities.utils
Signed-off-by: PoJuDeSu <spes9850401@gmail.com>
@poju3185
Copy link
Contributor Author

I've updated my commit with the sign-off. Thanks for the reminder!

@keshav-space keshav-space added VulnTotal Tool for cross-validating vulnerability labels May 13, 2024
@keshav-space keshav-space changed the title Fix #1443 Update import in vulntotal datasources Update GitHub GraphQL import in vulntotal datasources May 13, 2024
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @poju3185, merging!

@keshav-space keshav-space merged commit 045fedd into nexB:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VulnTotal Tool for cross-validating vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppRegistryNotReady error when setting up vulntotal
2 participants