Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22 testing #2171

Open
kibertoad opened this issue Apr 29, 2024 · 9 comments
Open

Node 22 testing #2171

kibertoad opened this issue Apr 29, 2024 · 9 comments

Comments

@kibertoad
Copy link

Is your feature request related to a problem? Please describe.

Node 22 is not currently officially supported by Node-Newrelic, and is not included in CI matrix.

Feature Description

Fix whatever compatibilities with Node 22 there might be, make CI pass, include Node 22 in the CI matrix.

Priority

Please help us better understand this feature request by choosing a priority from the following options:
[Really Want]

@workato-integration
Copy link

@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Apr 29, 2024
@jsumners-nr
Copy link
Contributor

Please see #2164

For what it's worth, Node 22 will not be labeled as LTS by upstream until October of 2024. Until then, it is not recommended to use Node 22 for production systems.

@bizob2828
Copy link
Member

@kibertoad based on our initial CI runs this will be a rather clean upgrade for our agent. However, it is not on our roadmap for at least a quarter. As @jsumners-nr said, we only support LTS versions and we have a few months until 22 is in LTS.

@bizob2828
Copy link
Member

Linking internal doc that's tracking CI runs

@kibertoad
Copy link
Author

kibertoad commented May 6, 2024

@bizob2828 What are the implications for that if we decide to run 22 in production, other than "Don't complain about things being broken if you use it"? I remember older New Relic versions warning about "Not adding native metric sampler" about Node 20, which I assume had negative perf impact (see #1712). Will same thing happen for Node 22 now?

@bizob2828
Copy link
Member

@kibertoad we do not support running the agent in production with Node 22 until it is LTS.

@kibertoad
Copy link
Author

@bizob2828 Yes, but what does "we do not support" mean? Does that mean that it might work, but if it doesn't then New Relic won't address the issues (which is fair), or is it already known up-front that there will be certain issues?

@bizob2828
Copy link
Member

bizob2828 commented May 6, 2024

@kibertoad "we do not support" means we aren't sure what works and what doesn't. It's use at your own risk and don't reach out to us if you have problems 😄 . So we recommend to not use Node 22 with New Relic Node.js agent until we officially support it. Preliminary CI runs show this will be a very low effort. But we will not go into the analysis until our team actually works on adding support for Node 22. Frankly, you shouldn't be using a Node.js version that isn't LTS so any other conversations are moot.

@kibertoad
Copy link
Author

Gotcha. Thank you for the explanation.

@workato-integration workato-integration bot changed the title Support for Node 22 Node 22 testing May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Node.js Engineering Board
  
Triage Needed: Unprioritized Features
Development

No branches or pull requests

3 participants