Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to run an async spec and hooks to spec #1936

Closed
bizob2828 opened this issue Jan 8, 2024 · 2 comments
Closed

Provide ability to run an async spec and hooks to spec #1936

bizob2828 opened this issue Jan 8, 2024 · 2 comments

Comments

@bizob2828
Copy link
Member

Is your feature request related to a problem? Please describe.

We have a need in aws sdk instrumentation to run async operations to return the specification for a given function spec, bedrock spec.

Feature Description

Allow async calls to get shim spec, calling after and inContext hooks. Currently they are called sync and if you want to do some async operation you have to get creative.

Additional context

It's probably worth re-evaluating the instrumentation APIs(shim). A lot has evolved since they are created and we're bolting on functionality as we need it but may be time for a holistic solution. It also may be hard to do this request because we return sync wrappers so we might have to be smarter with our wraps based on the original function. I don't think there will be a need to do something async in a sync function.

Priority

[Really Want]

@workato-integration
Copy link

@bizob2828
Copy link
Member Author

We refactored code to where this is no longer a need

Node.js Engineering Board automation moved this from Triage Needed: Unprioritized Features to Done: Issues recently completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

No branches or pull requests

1 participant