Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated text #780

Merged
merged 5 commits into from Sep 17, 2021
Merged

Updated text #780

merged 5 commits into from Sep 17, 2021

Conversation

elucus
Copy link
Contributor

@elucus elucus commented Sep 16, 2021

Updated wording related to DT and CAT.

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Describe the changes present in the pull request

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

Updated wording related to DT and CAT.
kaylareopelle
kaylareopelle previously approved these changes Sep 16, 2021
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for catching this, @elucus!

Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! TY!

@tannalynn tannalynn merged commit 125f835 into dev Sep 17, 2021
@kaylareopelle kaylareopelle added this to In progress in Ruby Engineering Board via automation Sep 17, 2021
@angelatan2 angelatan2 moved this from In progress to Done/Pending Release in Ruby Engineering Board Sep 22, 2021
@kaylareopelle kaylareopelle deleted the el-docs-update branch November 29, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Ruby Engineering Board
  
Code Complete/Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants