Fix multiverse "rest" group when running multiple groups #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"rest" group when passing in multiple groups
tannalynn
changed the title
kaylareopelle
approved these changes
Sep 16, 2021
Closed
angelatan2
moved this from In progress
to Done/Pending Release
in Ruby Engineering Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Adds a fix to the way multiverse checks the "rest" group (every suite not in any other group) when passing in multiple groups at the same time. previously it would skip the rest group check, but this has been fixed.
This PR also includes a fix for a failing bunny test that was previously not being run in the CI due to this multiverse bug.
Reviewer Checklist