Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use procs for code_header and code_footer in add_method_tracer #719

Closed
tannalynn opened this issue Jul 7, 2021 · 0 comments · Fixed by #728
Closed

Use procs for code_header and code_footer in add_method_tracer #719

tannalynn opened this issue Jul 7, 2021 · 0 comments · Fixed by #728
Assignees
@amhuntsman
Projects
Ruby Engineering Board
Milestone
8.0.0 Ruby Agent ...

Comments

@tannalynn
Copy link
Contributor

Currently, the agent allows a string to be passed as an optional parameter for the code_header and the code_footer. We are moving away from using string interpolation in the add_method_tracer, so we should update this to accept a proc for these optional params.
@tannalynn tannalynn added this to Triage in Ruby Engineering Board via automation Jul 7, 2021
@angelatan2 angelatan2 moved this from Triage to To do in Ruby Engineering Board Jul 8, 2021
@amhuntsman amhuntsman moved this from To do to In progress in Ruby Engineering Board Jul 16, 2021
@amhuntsman amhuntsman self-assigned this Jul 16, 2021
@amhuntsman amhuntsman mentioned this issue Jul 19, 2021
Merged
5 tasks
@tannalynn tannalynn linked a pull request Jul 19, 2021 that will close this issue
Refactor method tracers to use Module#prepend, no longer class_eval strings #728
Merged
5 tasks
Ruby Engineering Board automation moved this from In progress to Done/Pending Release Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amhuntsman amhuntsman

Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Ruby Engineering Board
  
Code Complete/Done
Milestone
8.0.0 Ruby Agent Major Release
2 participants
@amhuntsman @tannalynn