Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method tracer to use Module#prepend #717

Closed
tannalynn opened this issue Jul 7, 2021 · 0 comments · Fixed by #728
Closed

Update method tracer to use Module#prepend #717

tannalynn opened this issue Jul 7, 2021 · 0 comments · Fixed by #728

Comments

@tannalynn
Copy link
Contributor

tannalynn commented Jul 7, 2021

Currently our method tracer uses an eval'ed string with method chaining, however we want to update this to no longer use string eval, and to use Module#prepend instead of method chaining. The args should use (...) on ruby 2.7+.
Also this breaking change may break some our auto instrumented libraries, so updating those uses of add_method_tracer is important as well.
For more details please see #502

@tannalynn tannalynn added this to Triage in Ruby Engineering Board via automation Jul 7, 2021
@angelatan2 angelatan2 moved this from Triage to To do in Ruby Engineering Board Jul 8, 2021
@amhuntsman amhuntsman self-assigned this Jul 14, 2021
@angelatan2 angelatan2 moved this from To do to In progress in Ruby Engineering Board Jul 15, 2021
Ruby Engineering Board automation moved this from In progress to Done/Pending Release Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Ruby Engineering Board
  
Code Complete/Done
2 participants