Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc gemlist #1828

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Update grpc gemlist #1828

merged 1 commit into from
Feb 17, 2023

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Feb 17, 2023 •
edited

Lock grpc dependency google-protobuf to 3.21.12 for Rubies less than 2.5.9.

google-protobuf 3.22 depends on ruby >=2.6, so we need to pin the version.

@github-actions
Copy link

SimpleCov Report

Coverage Threshold
Line 93.93% 93%
Branch 85.34% 84%

@hannahramadan hannahramadan marked this pull request as ready for review February 17, 2023 19:08
tannalynn
tannalynn approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hannahramadan hannahramadan merged commit 9b6579b into dev Feb 17, 2023
@hannahramadan hannahramadan deleted the update_grpc_gemlist branch February 17, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannalynn tannalynn tannalynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hannahramadan @tannalynn