Update CHANGELOG #1827
Merged
Update CHANGELOG #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CHANGELOG to add feedback given in the migration guide
tannalynn
reviewed
Feb 17, 2023
CHANGELOG.md
Outdated
| - **Add Fiber Instrumentation** | ||
| This may be a breaking change if you are currently using custom thread instrumentation. New transactions inside of threads will no longer be started if one already exists. [PR#1767](https://github.com/newrelic/newrelic-ruby-agent/pull/1767) | ||
|
|
||
| - **Add Fiber instrumentation** | ||
|
|
||
| `Fiber` instances are now automatically instrumented similarly to `Thread` instances. This can be configured using `instrumentation.fiber`. [PR#1802](https://github.com/newrelic/newrelic-ruby-agent/pull/1802) |
There was a problem hiding this comment.
I don't know how it looks on the docs website, but I think GitHub now supports links within single back tick code snippets.
All this is to say, what do you think about linking the config options to their location on our config doc?
There was a problem hiding this comment.
I'll have to look into the single back tick. But the config option is now linked. Note: the docs site isn't live yet so the link doesn't work quite yet.
SimpleCov Report
|
1 similar comment
SimpleCov Report
|
kaylareopelle
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CHANGELOG to add feedback given in the migration guide
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Describe the changes present in the pull request
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist