Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable web transaction name #475

Open
giladmaya opened this issue Feb 3, 2022 · 14 comments
Open

Configurable web transaction name #475

giladmaya opened this issue Feb 3, 2022 · 14 comments

Comments

@giladmaya
Copy link

I'm using Flask framework, and the web transaction name is automatically determined by callable_name of function.
As a result, stakeholders that access NewRelic dashboards cannot understand which endpoint is related to the transaction.

I would like to have the option to configure the web transaction name according to the rule, which more informative and is known by other stakeholders.

I've considered using set_transaction_name but we don't use new relic agent directly in our code, and doing so would not be as clean as having it configured as part of agent initialisation.

It's a feature that we must have in order to be able to handle production failures rapidly (currently we have to lookup the relevant function in our code base which wastes precious time)

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@billcrook
Copy link

Supporting this in starlette would be nice as well.

@billcrook
Copy link

Looks like encode/starlette#685 would make this a bit easier.

@stale
Copy link

stale bot commented Oct 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2022
@billcrook
Copy link

bump

@stale stale bot removed the stale label Oct 17, 2022
@hmstepanek
Copy link
Contributor

hmstepanek commented Jan 17, 2023

Hi! Thanks for submitting this feature request. Just so I make sure I understand what you are asking for here:

You would like the transaction name to be the endpoint name/path instead of the callable name so instead of something like
module:function it would be something like api/v1/endpoint.

AND

You would like this to be configurable via something like transaction_name.set_name = 'endpoint' export NEW_RELIC_TRANSACTION_NAME_SET_NAME=endpoint for example in the agent config file or as an environment variable respectively so that all transaction names would be set as their endpoint/path names instead of their callable names.

Is that correct?

@billcrook
Copy link

billcrook commented Jan 18, 2023

You would like the transaction name to be the endpoint name/path instead of the callable name so instead of something like module:function it would be something like api/v1/endpoint.

Sounds correct to me. IIRC, this is how other newrelic agents (java/node) report transaction names OOTB.

@hmstepanek
Copy link
Contributor

Posting some additional relevant research/info for this feature request:

The Java agent optionally supports transaction naming based on endpoint when enable_auto_transaction_naming is set to False. There is a cautionary statement at the bottom of this setting about metric grouping issues. Note, in order to distinguish between the same api endpoint being called with a different method the method is included after the api endpoint path name: WebTransaction/RestWebService/customers/{id} (GET).

@stale
Copy link

stale bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 2, 2023
@billcrook
Copy link

bump

@stale stale bot removed the stale label Apr 2, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2023
@billcrook
Copy link

bump

@stale stale bot removed the stale label Jun 27, 2023
@Ak-x
Copy link

Ak-x commented Aug 24, 2023

Hello @billcrook if you would like to submit a PR our team would be happy to review it. This is not currently on our roadmap.

@billcrook
Copy link

While I appreciate the opportunity, I must respectfully decline to offer pro-bono services for a publicly-traded company. I'll be exploring other Python-friendly APM options. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants