Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite tracing spec compliance #430

Merged
merged 8 commits into from Nov 11, 2021

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Nov 11, 2021

Before contributing, please read our contributing guidelines and code of conduct.

Overview

  • Fix issue with gRPC subchannels staying open under infinite tracing
  • Remove pinned gRPC version
  • Refactor gRPC backoff to match connection spec

Related Github Issue

N/A

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

Mega-Linter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 0.4s
✅ PYTHON black 2 0 0 0.35s
✅ PYTHON flake8 2 0 0.33s
✅ PYTHON isort 2 0 0 0.17s
✅ PYTHON pylint 2 0 2.21s

See errors details in artifact Mega-Linter reports on GitHub Action page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@TimPansino TimPansino marked this pull request as ready for review November 11, 2021 21:40
@TimPansino TimPansino requested a review from a team as a code owner November 11, 2021 21:40
@lrafeei lrafeei added this to the 7.2.4.171 milestone Nov 11, 2021
@lrafeei lrafeei merged commit 6872298 into main Nov 11, 2021
@lrafeei lrafeei deleted the fix-infinite-tracing-spec-compliance branch November 11, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants