Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FastAPI Context Propagation #420

Merged
merged 13 commits into from Nov 3, 2021
Merged

Fix FastAPI Context Propagation #420

merged 13 commits into from Nov 3, 2021

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Oct 25, 2021 •
edited

Overview

  • A bug in context propagation resulting from instrumentation of Starlette's run_in_threadpool caused redundant instrumentation to issue Runtime instrumentation errors. This has been corrected.
  • Refactor of existing context propagation to use centralized context manager API.

Related Github Issue

Closes #419

Testing

Negative testing done, caplog should be sufficient to catch regressions.

TimPansino and others added 3 commits October 25, 2021 16:15
@TimPansino @lrafeei
Fix context propagation in fastapi.
806d89b 
Co-authored-by: Lalleh Rafeei <lrafeei@users.noreply.github.com>
@TimPansino
Add testing for context propagation errors
e0c03f3
@TimPansino
Format
0563678
@github-actions
Copy link

github-actions bot commented Oct 25, 2021 •
edited

Mega-Linter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 9 0 0.59s
✅ PYTHON black 9 0 0 0.5s
✅ PYTHON flake8 9 0 0.47s
✅ PYTHON isort 9 0 0 0.19s
✅ PYTHON pylint 9 0 6.76s

See errors details in artifact Mega-Linter reports on GitHub Action page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@TimPansino TimPansino marked this pull request as ready for review October 26, 2021 18:32
@TimPansino TimPansino requested a review from a team as a code owner October 26, 2021 18:32
@lrafeei lrafeei merged commit 768019d into main Nov 3, 2021
@lrafeei lrafeei deleted the fix-fastapi-context branch November 3, 2021 22:30
@umaannamalai umaannamalai added this to the 7.2.3.170 milestone Nov 4, 2021
@DmytroLitvinov DmytroLitvinov mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrafeei lrafeei lrafeei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.3.170
Development

Successfully merging this pull request may close these issues.

FastAPI Context Propagation Runtime Instrumentation Error
3 participants
@TimPansino @lrafeei @umaannamalai