Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add celery args as custom attributes #215

Open
daveisfera opened this issue May 13, 2021 · 25 comments
Open

Add celery args as custom attributes #215

daveisfera opened this issue May 13, 2021 · 25 comments

Comments

@daveisfera
Copy link

Is your feature request related to a problem? Please describe.

Custom attributes are very useful, but having to manually set them for celery task is cumbersome

Feature Description

Automatically add scalar arguments from a celery task as custom attributes (assuming that a custom attribute that's non-scalar (like dict, list, set, etc) is problematic)

Describe Alternatives

Current option is to manually add them and this is a pain and easy to forget

Additional context

This would make the celery integration even more powerful than it already is and make a powerful feature from New Relic (i.e. custom attributes) instantly available to users out of the box.

Priority

Really Want

@stale
Copy link

stale bot commented Jul 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 12, 2021
@daveisfera
Copy link
Author

This is still an outstanding request and would love to have it considered for an addition in a future release

@stale stale bot removed the wontfix label Jul 12, 2021
@stale
Copy link

stale bot commented Sep 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 10, 2021
@daveisfera
Copy link
Author

This is still an outstanding request and would love to have it considered for an addition in a future release

@stale stale bot removed the stale label Sep 10, 2021
@stale
Copy link

stale bot commented Nov 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 10, 2021
@daveisfera
Copy link
Author

This is still an outstanding request and would love to have it considered for an addition in a future release

@stale stale bot removed the stale label Nov 10, 2021
@stale
Copy link

stale bot commented Jan 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2022
@daveisfera
Copy link
Author

This is still an outstanding request and would love to have it considered for an addition in a future release

@stale stale bot removed the stale label Jan 10, 2022
@stale
Copy link

stale bot commented Mar 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 12, 2022
@daveisfera
Copy link
Author

This is still an outstanding request that should be a relatively minor change with a big benefit

@stale stale bot removed the stale label Mar 12, 2022
@stale
Copy link

stale bot commented Jun 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 13, 2022
@daveisfera
Copy link
Author

This is still an outstanding request that should be a relatively minor change with a big benefit

@stale stale bot removed the stale label Jun 13, 2022
@aleksanb
Copy link

We want this as well.
I'll have to implement this myself for now.

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2022
@daveisfera
Copy link
Author

This is still an outstanding request that should be a relatively minor change with a big benefit

@aleksanb
Copy link

aleksanb commented Oct 3, 2022

This is the solution we went with on our end, for future reference:

class CustomBaseTask(Task):
    """
    Annotates the new relic trace with args and kwargs.
    """

    def __call__(self, *args, **kwargs):
        if newrelic.agent.current_transaction():
            parameters = make_custom_parameters_from_celery_task(self.name, args, kwargs)
            newrelic.agent.add_custom_parameters(parameters)

        return super().__call__(*args, **kwargs)

@Ak-x
Copy link

Ak-x commented Oct 7, 2022

Thank you for the request, we have provided this issue to our product team for visibility and prioritization.

@stale stale bot removed the stale label Oct 7, 2022
@stale
Copy link

stale bot commented Dec 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 24, 2022
@aleksanb
Copy link

Do not close, bot!

@stale stale bot removed the stale label Dec 24, 2022
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 18, 2023
@daveisfera
Copy link
Author

This is still a valid request

@stale stale bot removed the stale label Mar 18, 2023
@stale
Copy link

stale bot commented May 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 22, 2023
@daveisfera
Copy link
Author

Still a request that would be helpful

@stale stale bot removed the stale label Aug 24, 2023
@Ak-x
Copy link

Ak-x commented Aug 24, 2023

Hello @daveisfera / @aleksanb, if you all are interested in submitting a PR; our team can review it.

@daveisfera
Copy link
Author

I wish that I could but I have no idea how this code works and don't have time figure out how to change code for a product I already pay for to do what it already should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants